Skip to content

[CF1] cert warning #20826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[CF1] cert warning #20826

merged 1 commit into from
Mar 17, 2025

Conversation

@deadlypants1973
Copy link
Contributor

@deadlypants1973 deadlypants1973 commented Mar 14, 2025

Summary

PCX-15665

Screenshots (optional)

Screenshot 2025-03-14 at 15 58 05

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@deadlypants1973 deadlypants1973 requested review from a team, kkrum and ranbel as code owners March 14, 2025 14:59
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 14, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated the documentation for user-side certificates to clarify installation requirements for successful device posture checks.

  • Added a caution note regarding certificate installation locations for device posture checks.
  • Clarified that certificates should be installed in the Current User Store for successful posture checks.

Modified Files

  • src/content/docs/cloudflare-one/connections/connect-devices/user-side-certificates/manual-deployment.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

Preview URL: https://86c6c35e.preview.developers.cloudflare.com
Preview Branch URL: https://kate-fixes-certcheck.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/cloudflare-one/connections/connect-devices/user-side-certificates/manual-deployment/ https://kate-fixes-certcheck.preview.developers.cloudflare.com/cloudflare-one/connections/connect-devices/user-side-certificates/manual-deployment/

Oxyjun
Oxyjun reviewed Mar 17, 2025
View reviewed changes
...docs/cloudflare-one/connections/connect-devices/user-side-certificates/manual-deployment.mdx
The root certificate is now installed and ready to be used.

:::caution
If your certificate is installed in the **Local Machine Store**, the [device posture check](/cloudflare-one/identity/devices/warp-client-checks/) looking for a certificate will fail. Install the certificate in the **Current User Store** to ensure a successful posture device check.
Copy link
Contributor

@Oxyjun Oxyjun Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your certificate is installed in the **Local Machine Store**, the [device posture check](/cloudflare-one/identity/devices/warp-client-checks/) looking for a certificate will fail. Install the certificate in the **Current User Store** to ensure a successful posture device check.
If your certificate is installed in the **Local Machine Store**, the [device posture check](/cloudflare-one/identity/devices/warp-client-checks/), which looks for a certificate, will fail. Install the certificate in the **Current User Store** to ensure a successful posture device check.

@deadlypants1973 deadlypants1973 merged commit ba57317 into production Mar 17, 2025
12 checks passed
@deadlypants1973 deadlypants1973 deleted the kate/fixes-certcheck branch March 17, 2025 14:39
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@deadlypants1973 @RebeccaTamachiro
[CF1] cert warning (#20826)
395e4bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oxyjun Oxyjun Oxyjun approved these changes

@ranbel ranbel Awaiting requested review from ranbel ranbel is a code owner

+1 more reviewer

@kkrum kkrum kkrum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kkrum kkrum

@ranbel ranbel

Labels

product:cloudflare-one size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deadlypants1973 @kkrum @Oxyjun @ranbel